-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
MNT: fix labeller #27694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: fix labeller #27694
Conversation
Comment regarding typo, for reference: However, I'd like to hear from @QuLogic as to whether the lack of checkout is intentional or not. |
🤦♀️ knew I saw that somewhere |
And for checkout, maybe has to do w/ https://github.com/actions/labeler#notes-regarding-pull_request_target-event |
I think you were looking at old docs (and the referenced issue is older than v5); the v5 ones don't mention needing a checkout. In fact, the docs say it will read from the source repo (which it has been doing all this time). And I don't think it would have any effect, as So the changes to the workflow appear superfluous, as they are just setting configuration to the defaults and adding a checkout that doesn't do anything. |
I was just confused why it was still getting that error message, but just undid those changes. |
PR summary
According to the error message and the labeler docs, I think this was a typo.
eta: also I think running into actions/labeler#628 and not sure if the fix is it needs to be fixed here and that'll fix it or combined w/ a checkout option.