-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
MNT: deprecate draw method args and kwargs #27768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I am confused by the stubtest failure, which I have reproduced locally
|
Had a bit of a dig, and that's because Lines 20 to 28 in d2cc4d0
I'm not sure why the purpose of this is, and why it's not playing ball with |
Ahh... when used for non- However, for variadic args no such sentinel is used, so it doesn't actually break so the entry is unused. |
Pushed an update to the automatic detection code to parse out when a vararg/kwarg is Also added a comment that at least indicates the reason it is there/what is happening. |
Thanks @ksunden! |
PR summary
Closes #27745
I am very much appreciating how easy the deprecation module makes this 👍
PR checklist