Make mypy a bit stricter #27796
Merged
Make mypy a bit stricter #27796
+38
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also fix some types to fix those warnings.
These options are based on Scientific Python development guide: https://learn.scientific-python.org/development/guides/repo-review/?repo=matplotlib%2Fmatplotlib&branch=main
Instead of putting them in CI, so that one can run `mypy` by itself and not have to remember the flags to match CI.
ksunden
approved these changes
Feb 16, 2024
timhoffm
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This follows some suggestions from Scientific Python's Repo-Review (I don't agree with everything there, but at least the MyPy stuff seems fine), and also moves config from the CI to
pyproject.tomlfor re-use/visibility.PR checklist