Add side option to violinplot #27815
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
There was a problem hiding this comment.
Fairly minor things:
Testing standard practices (using new style, random seed)
- You were matching local examples, but we do have preferences for new tests
Using helper function for validation.
As this is still in draft, didn't look too hard at the docs changes yet, but figured I'd point to some of our tooling early on.
|
Can I fix the failed check without creating a new PR? (I changed the test image half-way through) |
|
Yes, you can (and in fact opening a new PR alone would not even prevent the flag): We have a guide on interactive rebasing here: https://matplotlib.org/devdocs/devel/development_workflow.html#rewrite-commit-history At minimum you'd need to squash together the two commits that added images. The easiest way to do that is probably to just squash all the commits down to one commit (its a small enough change for that) If you do not want to mess with it yourself, we can do it as well. |
7a252c3 to
dc97efb
Compare
|
I tried myself, failed a little, but I think I managed to squash the commits. |
There was a problem hiding this comment.
As one can see in the image, there's a gap where extrema line and vertical line meet. We could investigate whether hard-coding capstyle="projecting" makes sense for extrema lines of half violins.
https://matplotlib.org/devdocs/gallery/lines_bars_and_markers/capstyle.html#capstyle
cd8ef8d to
50d2950
Compare
50d2950 to
2782e0e
Compare
add test for side option in violinplot add whats new for side in violinplot add violin side option to _axes.pyi and pyplot.py use side option in violinplot also for lines add side option to violinplot example use newer style and correct seed in violin test update image change option naming use proper syntax for code in violin docs Co-authored-by: Kyle Sunden <git@ksunden.space> add changed violinplots (capstyle=projecting) hardcode capstyle only for left-right violins fix typo
2782e0e to
0adab7b
Compare
Thanks to you! This was very pleasant and I will definitely contribute to matplotlib in the future now that I know how you do things :) |
|
Congrats on your merged PR! Thanks |
PR summary
This PR adds a
sideparameter to the violin plot which allows to plot only one half of the violin.I added an image comparison for vertical and horizontal violins and two subplots in the gallery example.
closes #27812
PR checklist