Make example in legend_elements doc more generalisable #27846
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I mentioned it it the comment at the top of this PR, but I think this is probably enough to close that PR. I'll update the comment at the top to link it. |
|
Azure failure is clearly unrelated. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 3, 2024
…e generalisable
rcomer
added a commit
that referenced
this pull request
Mar 3, 2024
…846-on-v3.8.x Backport PR #27846 on branch v3.8.x (Make example in legend_elements doc more generalisable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Fixes #27826 - I'm guessing the author of that issue copied the example in the docstring, and then found it didn't work for large values. Since the text says "creates three legend elements, one for each color" I think it makes sense to put the
num=Nonekwarg here to make sure "one for each color" remains true for larger data sizes.PR checklist