Doc change for matshow function clarifying row and column positions #27855
Conversation
|
You can push changes to the same branch rather than opening and closibg PRs |
|
Yeah, that was the plan, but I'm still figuring my ways around github, and I faced an issue where each subsequent PR had the history of commits alon with it. I tried looking for methods to fix this, and I found cherry-pick and branch-to-branch pushing PRs. Later I figured out, the changes I tried to implement somehow ended up in the main branch, and reverting merges is already sufficiently painful, due to which I deleted the fork and created a new one :) Any suggestions/comments would be welcome |
|
@Impaler343 our contributors’ guide here may help |
|
Oh wow, thank you very much! I think I need to read the entire documentation before starting off. Thanks! |
|
Superseeded by #27857. |
PR summary
This changes the documentation of the matshow function, making it clearer as to which dimension corresponds to which number in the array passed to the function. The convention used is standard practice, where the first number(rows) corresponds to the length of the vertical column and the second number(columns) corresponds to the length of the horizontal column.
Closes #27852
PR checklist