Correctly set temporary pdf/pgf backends #27869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `FigureCanvasPdf(figure)` will call `figure.set_canvas(self)`, meaning the `cbook._setattr_cm` context manager that wraps this change will see the _new_ canvas, and the old canvas isn't restored. Instead, just pass the `backend` parameter, as `savefig` already knows how to correctly save and restore the canvas if it needs to change backends. Fixes matplotlib#27865
|
Hey, could you commit the documentation change that I mentioned earlier in the issue #27865 as well? |
anntzer
approved these changes
Mar 6, 2024
timhoffm
approved these changes
Mar 6, 2024
|
I’m merging as is. Adding the doc fix here or creating a separate PR for it is an equal amount of work. So, let’s already take this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Calling
FigureCanvasPdf(figure)will callfigure.set_canvas(self), meaning thecbook._setattr_cmcontext manager that wraps this change will see the new canvas, and the old canvas isn't restored.Instead, just pass the
backendparameter, assavefigalready knows how to correctly save and restore the canvas if it needs to change backends.Fixes #27865
PR checklist