doc: use different variables for color/x axis in example #27871
Closed
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Mar 6, 2024
Inspired by but independent of matplotlib#27871. This example is much simpler, but conveys the same LineCollection aspects - with the exception of not using masked arrays. But I argue that this first example should be simple and using masked arrays rather distracts from the core aspects of LineCollection.
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Mar 6, 2024
Inspired by but independent of matplotlib#27871. This example is much simpler, but conveys the same LineCollection aspects - with the exception of not using masked arrays. But I argue that this first example should be simple and using masked arrays rather distracts from the core aspects of LineCollection.
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Mar 6, 2024
Superseeds matplotlib#27871. This example is much simpler, but conveys the same LineCollection aspects - except for not using masked arrays. But I argue that this the example should be simple and using masked arrays rather distracts from the core aspects of LineCollection. If there's concern of not showing masked array support, we should add a third plot for that.
|
Sorry for jumping ahead, but this example has many more shortcomings, so that I did a complete rewrite in #27873. |
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Mar 6, 2024
Superseeds matplotlib#27871. This example is much simpler, but conveys the same LineCollection aspects - except for not using masked arrays. But I argue that this the example should be simple and using masked arrays rather distracts from the core aspects of LineCollection. If there's concern of not showing masked array support, we should add a third plot for that.
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Mar 6, 2024
Superseeds matplotlib#27871. This example is much simpler, but conveys the same LineCollection aspects - except for not using masked arrays. But I argue that this the example should be simple and using masked arrays rather distracts from the core aspects of LineCollection. If there's concern of not showing masked array support, we should add a third plot for that.
|
A complete rewrite sounds much better! |
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Mar 7, 2024
Superseeds matplotlib#27871. This example is much simpler, but conveys the same LineCollection aspects - except for not using masked arrays. But I argue that this the example should be simple and using masked arrays rather distracts from the core aspects of LineCollection. If there's concern of not showing masked array support, we should add a third plot for that.
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Mar 7, 2024
Superseeds matplotlib#27871. This example is much simpler, but conveys the same LineCollection aspects - except for not using masked arrays. But I argue that this the example should be simple and using masked arrays rather distracts from the core aspects of LineCollection. If there's concern of not showing masked array support, we should add a third plot for that.
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Mar 8, 2024
Superseeds matplotlib#27871. This example is much simpler, but conveys the same LineCollection aspects - except for not using masked arrays. But I argue that this the example should be simple and using masked arrays rather distracts from the core aspects of LineCollection. If there's concern of not showing masked array support, we should add a third plot for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
I was trying to understand adding colormapping to a
LineCollectionand was confused by the example: https://matplotlib.org/stable/gallery/shapes_and_collections/line_collection.htmlIn this PR I:
arrayis forxfor thearray. I was further confused by this, at first I thought this was how you set the x positions.Part of the issue here is that if you chase down the docstrings from
LineCollection->Collectionyou never see any mention ofarray. In a separate PR I can make an addition to theCollectiondocstringPR checklist
-NA Plotting related features are demonstrated in an example