Skip to content

Fix cbook style #27922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2024
Merged

Fix cbook style #27922

merged 1 commit into from
Mar 15, 2024

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Mar 14, 2024 •
edited
Loading

  • add missing functions to cbook.pyi
  • PEP8 conform newlines in test_cbook.py
  • Turn multiline comment at beginning of test function into a docstring. - Apparently flake8 D213 interprets comments as docstrings as well?!?
    grafik

@timhoffm timhoffm added this to the v3.9.0 milestone Mar 14, 2024
@timhoffm
Fix cbook style
0389fb1 
- add missing functions to cbook.pyi
- PEP8 format conform test
@timhoffm timhoffm mentioned this pull request Mar 14, 2024
Merged
2 tasks
@QuLogic
Copy link
Member

QuLogic commented Mar 14, 2024

It doesn't do that; you must have seen a test run from before #22845.

@timhoffm
Copy link
Member Author

You mean the flake8 D213 thing? Anyway, it doesn't hurt to have docstrings instead of comments. I think we still can take the PR as is.

@QuLogic QuLogic merged commit 72731a5 into matplotlib:main Mar 15, 2024
@timhoffm timhoffm deleted the cbook-style-fix branch July 19, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timhoffm @QuLogic @tacaswell