Update "Created with" url in hand.svg #27933
Conversation
Current url points to online sextoys store.
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Indeed it does. |
|
A far as I can tell, this file is entirely unused (at least internally), is there any reason not to just remove it (and the png/pdf versions) entirely? I guess technically it is available to downstream toolbars... (It is also the only image in mpl-data that is not created with mpl itself, so another thought I had was to recreate in mpl) All that said, this is updating a comment that is pointing to a clearly wrong place (now, I suspect it was accurate at the time, this file was last edited 18 years ago, at least in contents). So I have no qualms with this change in the immediate term, just thought an even more complete solution may be possible. |
|
Merging over appveyor failure (which was in conda env creation, not even our own failure) as this is only editing a comment in an svg anyway. |
…933-on-v3.8.x Backport PR #27933 on branch v3.8.x (Update "Created with" url in hand.svg)
Current url points to online sextoys store.