Add support for horizontal CheckButtons #27946
Open
+135
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b58dc7d to
f92a95f
Compare
f92a95f to
873a3d8
Compare
|
As a general remark: The buttons are placed above the text: I believe the more common placement text next to the buttons: I'm not blocking, but we should be clear what the desired result is and we're not accidentally moving into an unwanted direction. |
A new optional keyword argument 'layout_direction' is introduced to control it. The new parameter defaults to 'vertical' for backwards compatibility.
|
I assume the reason for implementing it that way was that it was easier to implement. The latter requires accounting for the text width before placing the markers, while the former just places them equidistantly. |
873a3d8 to
9a5eb5b
Compare
|
You could still place equidistantly with text right of the buttons. The possible overlap issues are the same, except that you have a constant reserved space for the buttons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This is a followup to #13374, but for
CheckButtons. Also updates the test image to check both options.Feel free to review after #13374 or as a group. This is built on top of that one, so merging this would merge that as well.
PR checklist