gtk: Ensure pending draws are done before GTK draw #27988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, the resize event happens first, adds an idle draw callback, and then the widget draws itself. Since the draw callback only happens when _idle_, it happens after the draw, so the figure appears blank. After the mouse is released, the idle draw callback fires, and the figure appears again. This is already done in the Qt backend [1], and doing so ensures the figure remains visible during resizes with the mouse. [1] https://github.com/matplotlib/matplotlib/blob/0afc5d6ca49cf6e8aa1da76b5bab0faca2f340f2/lib/matplotlib/backends/backend_qtagg.py#L25
tacaswell
approved these changes
Mar 29, 2024
oscargus
approved these changes
Mar 29, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 29, 2024
dstansby
added a commit
that referenced
this pull request
Mar 29, 2024
…988-on-v3.8.x Backport PR #27988 on branch v3.8.x (gtk: Ensure pending draws are done before GTK draw)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Originally, the resize event happens first, adds an idle draw callback, and then the widget draws itself. Since the draw callback only happens when idle, it happens after the widget's draw, so the figure appears blank. After the mouse is released, the idle draw callback fires, and the figure appears again.
This is already done in the Qt backend [1], and doing so ensures the figure remains visible during resizes with the mouse.
This fixes the bug reported at #25861 (comment)
[1]
matplotlib/lib/matplotlib/backends/backend_qtagg.py
Line 25 in 0afc5d6
PR checklist