Add warning for multiple pyplot.figure calls with same ID #27992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Apr 3, 2024
tacaswell
reviewed
May 8, 2024
|
It looks like appveyor failed trying to install the codecov uploader. |
tacaswell
approved these changes
May 13, 2024
|
The test failures looked unrelated, re-running. |
c8e7a8e to
f36cdcf
Compare
Exclude the 'clear' argument
Made test more versatile
f36cdcf to
18eb3e7
Compare
tacaswell
reviewed
May 19, 2024
| else: | ||
| num = int(num) # crude validation of num argument | ||
| if any([figsize, dpi, facecolor, edgecolor, not frameon, | ||
| kwargs]) and num in allnums: |
There was a problem hiding this comment.
Reading this one more time, I think we also need the warning around line 988 for the case were someone does:
fig = plt.figure()
plt.figure(fig, figsize=(2, 2)) # this should warn as wellThere was a problem hiding this comment.
Yep, added that as well
|
Failing tests are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #27978. This hopefully adds the relevant warning discussed in the issue
PR checklist