Inform tool-manager that wx backend wants icons in svg format #28008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also #28007, which does essentially the same thing (though in the class definition, rather than in There is a Linting error, though only an extra space required for the inline comment. |
|
This also does not fix the appveyor problem, and I think that setting the value in the class definition as in #28007 is better |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactoring in PR #26710 modified the wx backend to use resolution-independent tool icons in
svgformat. But informing tool-manager of this change was not done. So toolbar icons do not work when using tool-manager in conjunction with the wx backend. This in particular triggered issue #28007This PR addresses this problem by informing tool-manager that the wx backend wants icons in svg format.