-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Named colors example #2801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Named colors example #2801
Conversation
I completely forgot that I was playing with named colors a long time ago, but I never got a script cleaned up enough for submission as an example. I was pretty happy with the output from this script, but the code is way to messy for an example: https://gist.github.com/tonysyu/8929788 Maybe you can take some of the ideas in my old script and clean it up. I like the clarity of your example code much better than mine, but I think the output in the linked script is a bit easier to read. |
We might like to put a black border around the colours so that the light ones stand out against a black background. |
@tonysyu I like your arrangement. |
@@ -0,0 +1,50 @@ | |||
import numpy as np | |||
import matplotlib.pyplot as plt | |||
from matplotlib import cbook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused import
This looks great: The layout is nice and the code is much easier to read than my original example. Could you add a docstring for the file describing the purpose of this example? I know it seems self-evident, but it's still helpful for someone browsing examples: https://github.com/matplotlib/matplotlib/wiki/MEP12#wiki-clean-up-guidelines |
Added the docstring, Is this enough for a description or is something more needed? |
all the |
@tacaswell I am not sure what you were refering to with "future-proofing" I added the typical
|
the |
👍 from me. |
👍 |
Addressing #2164