FIX: ensure images are C order before passing to pillow #28032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Apr 5, 2024
| @@ -205,6 +205,13 @@ def test_imsave(fmt): | |||
| assert_array_equal(arr_dpi1, arr_dpi100) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("origin", ["upper", "lower"]) | |||
| def test_imsave_rgba_origin(origin): | |||
| buf = io.BytesIO() | |||
There was a problem hiding this comment.
Optionally add a comment., why this test was added/ what it ensures.
oscargus
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
I'm a bit off w.r.t. release schedule so will not merge with 3.9-tag. But if it is OK to still backport, @tacaswell can self-merge, ideally after adding a comment about the reason for the test (but, yes, optional).
6e5d845 to
f8d8020
Compare
f8d8020 to
df29a4e
Compare
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 17, 2024
…assing to pillow
ksunden
added a commit
that referenced
this pull request
Apr 17, 2024
…032-on-v3.9.x Backport PR #28032 on branch v3.9.x (FIX: ensure images are C order before passing to pillow)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #28020
PR summary
PR checklist