Strip trailing spaces from log-formatter cursor output. #28056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trailing spaces were fine when the cursor position was shown as `x=... y=...`, but become very ugly now that it's `(x, y) = (..., ...)`.
story645
approved these changes
Apr 11, 2024
timhoffm
approved these changes
Apr 11, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 12, 2024
…r cursor output.
ksunden
reviewed
Apr 12, 2024
| @@ -1024,7 +1024,7 @@ def format_data(self, value): | |||
|
|
|||
| def format_data_short(self, value): | |||
| # docstring inherited | |||
| return '%-12g' % value | |||
| return ('%-12g' % value).rstrip() | |||
There was a problem hiding this comment.
Sorry for the post merge comment here, but why not just:
return f"{value:g}"The 12 in the format is adding padding that we are then just stripping away...
rcomer
added a commit
that referenced
this pull request
Apr 13, 2024
…056-on-v3.9.x Backport PR #28056 on branch v3.9.x (Strip trailing spaces from log-formatter cursor output.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trailing spaces were fine when the cursor position was shown as
x=... y=..., but become very ugly now that it's(x, y) = (..., ...). (#25556)(test e.g. with moving the cursor on a loglog() axes and looking at the coordinates display)
PR summary
PR checklist