Python 3 METH_VARARGS with METH_KEYWORDS #2807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S when setting METH_KEYWORDS
|
@mdehoon , I think you would be best to comment. |
|
Seems OK for start_event_loop. |
|
@mdehoon You're right. I had only looked at start_event_loop. That definitely should be METH_NOARGS. Update PR to include that fix as well. |
|
Looks fine to me. |
tacaswell
added a commit
that referenced
this pull request
Feb 20, 2014
Python 3 METH_VARARGS with METH_KEYWORDS
|
merged, thanks @cimarronm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
METH_VARARGSto the method definition flags in _macosx.m as Python 3 requiresMETH_VARARGSto be set whenMETH_KEYWORDSis set. This is already the case whereMETH_KEYWORDSis used elsewhere, namely _ttconv.cpp and cntr.c.Without this and executing within Python3 one will get the error
SystemError: Bad call flags in PyCFunction_Call. METH_OLDARGS is no longer supported!