Parent tk StringVar to the canvas widget, not to the toolbar. #28077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... because the toolbar may be a fake object (when using
rcParams["toolbar"] = "toolmanager").
Try with `rcParams["toolbar"] = "toolmanager; use("tkagg")` and
interactively saving the picture. No automated tests, sorry.
oscargus
approved these changes
Apr 15, 2024
timhoffm
approved these changes
Apr 15, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 15, 2024
…t, not to the toolbar.
ksunden
added a commit
that referenced
this pull request
Apr 17, 2024
…077-on-v3.9.x Backport PR #28077 on branch v3.9.x (Parent tk StringVar to the canvas widget, not to the toolbar.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... because the toolbar may be a fake object (when using rcParams["toolbar"] = "toolmanager").
Try with
rcParams["toolbar"] = "toolmanager; use("tkagg")and interactively saving the picture. No automated tests, sorry.Closes #28069 (I chose not to parent to None as suggested in the original issue because I'm not 100% sure this won't lead to variables being progressively leaked into tk's global namespace.)
Looks like a regression in 3.8 (#24531), so let's try to get this in 3.9.
PR summary
PR checklist