Clarify that findfont & _find_fonts_by_props return paths. #28078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially the previous wording for _find_fonts_by_props ("find font
families") was somewhat confusing, as "font families" are strings.
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 15, 2024
…props return paths.
ksunden
added a commit
that referenced
this pull request
Apr 17, 2024
…078-on-v3.9.x Backport PR #28078 on branch v3.9.x (Clarify that findfont & _find_fonts_by_props return paths.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially the previous wording for _find_fonts_by_props ("find font families") was somewhat confusing, as "font families" are strings.
PR summary
PR checklist