Skip to content

Update 3D orientation indication right away #28311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2024

Conversation

MischaMegens2
Copy link
Contributor

PR summary

Immediately update orientation indication in 3d plot when left mouse button is pressed or released (instead of requiring a mouse movement first): Issue #28310

PR checklist

- Immediately update orientation indication in 3d plot when left mouse button is pressed or released
- Addresses Issue matplotlib#28310
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work with MEP22 toolmanager, but I suspect that's just another symptom of #18007, and I think it's sufficient to just have a link to that limitation on the #18007 thread.

@tacaswell tacaswell merged commit a16ff16 into matplotlib:main May 29, 2024
@tacaswell
Copy link
Member

Locally confirmed that this worked and did not make the toolmanager version worse.

Thank you @MischaMegens2 !

@QuLogic QuLogic added this to the v3.10.0 milestone May 29, 2024
@MischaMegens2 MischaMegens2 deleted the orientation-indication branch May 29, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants