Skip to content

Fix missing font error when using MiKTeX #28340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

cesaryuan
Copy link
Contributor

@cesaryuan cesaryuan commented Jun 4, 2024

PR summary

Fix the missing font error when using MiKTeX as the LaTeX distribution. Close #28212.

Thanks to @anntzer for providing the code. I just copied and opened the pr as an exercise.

PR checklist

@cesaryuan cesaryuan changed the title Fix missing font error when using MikTeX Fix missing font error when using MiKTeX Jun 4, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@greglucas greglucas requested a review from anntzer June 8, 2024 21:15
@anntzer
Copy link
Contributor

anntzer commented Jun 9, 2024

It's not the nicest architecture and a test would have been nice, but that's the best I could come up with short of major surgery (and testing seems tedious to set up too), and it does fix a real bug.
As I basically wrote the patch, I'm not sure my review really counts, so I'll give a few days for anyone to object. If no one protests I'll merge.

@ksunden ksunden added this to the v3.10.0 milestone Jun 12, 2024
@ksunden ksunden merged commit bcaffa1 into matplotlib:main Jun 12, 2024
44 of 45 checks passed
@cesaryuan cesaryuan deleted the fix-miktex branch January 3, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for author
Development

Successfully merging this pull request may close these issues.

[Bug]: Matplotlib not work with MiKTeX.
5 participants