Add compilers to conda environment #28352
Conversation
|
Anyone can merge when green. |
|
Are CodeCov or AppVeyor relevant here? Mentioning as those appear to be the only failures |
|
Unfortunately, yes. We use the environment file on appveyor |
|
The error on AppVeyor suggests the compiler is not on the path Edit: When we used AppVeyor in conda-forge in the past, we would typically add a line like this to activate the compiler. Am not seeing that line in the AppVeyor configuration file in this repo, but maybe I'm missing it? |
|
Originally, we told Meson to enable the MSVC environment automatically; this was because AppVeyor had Strawberry Perl with its totally broken compilers on the path first. It seems that adding compilers from conda-forge causes MSVC to be hidden entirely, but that's sort of what we want anyway. I'll remove the |
This fixes issues with `libstdc++.so` when using a system with a newer compiler. In such cases, the compiler will create links to new symbols, but the shared library available at runtime from conda-forge will not have them available. This results in errors such as: ``` ImportError: /home/elliott/micromamba/envs/mpl-dev/bin/../lib/libstdc++.so.6: version `CXXABI_1.3.15' not found (required by /home/elliott/code/matplotlib/build/cp39/src/_c_internal_utils.cpython-39-x86_64-linux-gnu.so) ```
|
FWIW we now have Line 48 in 54729db |
|
All seems to be working now - just in case I'm missing something I'll let this sit for a few days, but if no-one objects after that I'll merge. |
PR summary
This fixes issues with
libstdc++.sowhen using a system with a newer compiler. In such cases, the compiler will create links to new symbols, but the shared library available at runtime from conda-forge will not have them available.This results in errors such as:
I'm fairly certain we have seen similar issues here or on Gitter, but am not aware of one at the moment.
@jakirkham also suggested adding
pythoneven if we don't pin it just to be explicit.PR checklist