DOC/ENH : get/set_size_inches #2836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added links between `get_size_inches` and `set_size_inches` Added an `np.array` call to `get_size_inches` to return a copy of the size, instead of a reference to the internal np.array. Closes matplotlib#2303
|
IMO, it would be nicer to have the See Also part as a section:: See Also Else, this looks good to me. 👍 for merge |
|
@NelleV is the in addition to or instead of the |
|
It would be in replacement of the .. alsosee:: |
|
Also very minor: maybe add a sentence how to convert inch in cm, for us Europeans. |
- better numpydoc style - added inch <-> cm conversion factor
|
LGTM |
| size : ndarray | ||
| The size of the figure in inches | ||
|
|
||
| Also See |
There was a problem hiding this comment.
re-reading, I don't get that. Happy for either Nelle to confirm, or we just apply the consistency rule and I'll happily merge.
There was a problem hiding this comment.
|
Other than that, I'll merge with gusto. 👍 |
|
@NelleV Just to check, I added a commit flipping the word order right before you merged. |
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Apr 16, 2014
- issue introduced in matplotlib#2836 - closes matplotlib#2982
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added links between
get_size_inchesandset_size_inchesAdded an
np.arraycall toget_size_inchesto return a copy ofthe size, instead of a reference to the internal np.array.
Closes #2303