Fix circleci yaml #28427
Merged
Fix circleci yaml #28427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Jun 19, 2024
|
Just wondering how this works with dependabot if the version is elsewhere? |
|
We could just increase the max line length to 119... |
|
For reference, Dependabot appears to only look at inlined comments following the SHA hash: Examples from their tests can be found in: (Mostly leaving this as a future reference for when this comes up again... who knows if I'll think to find this, but would rather have it if I can) |
QuLogic
approved these changes
Jun 19, 2024
rcomer
approved these changes
Jun 20, 2024
|
Added the backport commit to the existing #28426 |
rcomer
added a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Follow up to #28425 and #28413
YAML is sometimes confusing and puts the ending
\non a multiline string with|, which made the job fail.I moved the comment, hopefully it doesn't mess with dependabot being able to automatically update it, but the line was still too long with the comment on the same line.
PR checklist