Fix value error when set widget size to zero while using FigureCanvasQT #28523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
tacaswell
approved these changes
Jul 8, 2024
ksunden
approved these changes
Jul 8, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 8, 2024
… zero while using FiCureCanvasQT
timhoffm
added a commit
that referenced
this pull request
Jul 8, 2024
…523-on-v3.9.x Backport PR #28523 on branch v3.9.x (Fix value error when set widget size to zero while using FiCureCanvasQT )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Resize the Qwidget causes the FigureCanvasQT width to 0 will raise:
RuntimeWarning: divide by zero encountered in scalar divide fig_aspect = bb.height / bb.widthResize the Qwidget causes the FigureCanvasQT height to 0 will raise:
ValueError: 'box_aspect' and 'fig_aspect' must be positiveChange FiCureCanvasQT widget size (w, h) from non-negative to positive to make sure fig_aspect is positive.
PR checklist