-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
counterclock parameter for pie #2853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you also and an entry I CHANGELOG, api_changes.rst and whats_New.rst? The two rst files are under doc. This is so your new feature gets advertised. |
Sorry, I was a little bit busy, and I will be completely offline for the next two weeks (since tomorrow). For whats_New, I think, it is too small changes Feel free to reject this pull request and make changes yourself, I will happy enough. |
That comment should have read: "Can you also add an entry in CHANGELOG, api_changes.rst and whats_New.rst? The two rst files are under doc." Sorry for the typos (I think I will blame my phone). |
Add line in changelog.
[tac edited to add markup] |
travis some times generates transient failures (or fails to set it's self up). Don't worry about it in this case. |
This looks good to me. The one other thing that is good to have is a test showing the function of the new feature. As you are about to go offline for two weeks, I will take care of the test for this feature. |
One last thing I just noticed, if the plot is ccw, should the starting angle also be shifted? |
I think not, cause situation simpler if one parameter controls only one thing -- only fractions direction in this case. |
Fair point (I had not fully grasped the difference that the starting position was an angle and the wedge sizes were fractions). I will merge this tonight unless there is protest. |
No description provided.