Skip to content

added tags to mplot3d examples #28568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2024
Merged

added tags to mplot3d examples #28568

merged 1 commit into from
Oct 16, 2024

Conversation

farquh
Copy link

@farquh farquh commented Jul 13, 2024 •
edited
Loading

PR summary

Improves documentation of mplot3d examples by adding tags.

PR checklist

@github-actions github-actions bot added the Documentation: examples files in galleries/examples label Jul 13, 2024
github-actions[bot]
github-actions bot reviewed Jul 13, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

QuLogic
QuLogic reviewed Jul 13, 2024
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix the linting error.

@QuLogic
Copy link
Member

QuLogic commented Jul 14, 2024

Sorry, I missed it earlier, but every tag list should be comma-separated.

@story645 story645 added mentored: sprint Issues intended and suitable for sprints Documentation: tags tagging examples + proposing new tags labels Jul 19, 2024
story645
story645 reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry it took so long to review this. Reviews are mostly fixing formatting - please let me know if you plan to finish this out or if someone should take over. Thanks!

@farquh
Copy link
Author

farquh commented Sep 1, 2024

Hi, sorry it took so long to review this. Reviews are mostly fixing formatting - please let me know if you plan to finish this out or if someone should take over. Thanks!

Sorry I missed this and also didn't respond for awhile. Someone else should probably take over. Thank you!

@rcomer
Copy link
Member

rcomer commented Sep 1, 2024

Someone else should probably take over.

Thanks for letting us know @farquh!

@QuLogic QuLogic added this to the v3.10.0 milestone Sep 14, 2024
@QuLogic
Copy link
Member

QuLogic commented Sep 14, 2024

I rebased and took care of the issues with the tags.

@scottshambaugh scottshambaugh merged commit 3c7bc45 into matplotlib:main Oct 16, 2024
28 checks passed
@scottshambaugh
Copy link
Contributor

Thank you @farquh for your work on this - it will be part of the upcoming v3.10 release. Congratulations on your first contribution to matplotlib, and we hope to see you again!

@scottshambaugh scottshambaugh mentioned this pull request Oct 16, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@story645 story645 story645 left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@scottshambaugh scottshambaugh scottshambaugh approved these changes

Assignees
No one assigned
Labels
Documentation: examples files in galleries/examples Documentation: tags tagging examples + proposing new tags mentored: sprint Issues intended and suitable for sprints topic: mplot3d
Projects
First Time Contributors
Status: Waiting for author
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@farquh @QuLogic @rcomer @scottshambaugh @story645