-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Doc: doc docs reorg #28578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Doc: doc docs reorg #28578
Conversation
There appear to be some broken references. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking again, I'm not quite sure on the breakup. The previous structure made sense to me
"Getting started" as contextual technical knowledge how to work on documentation.
Now "General file structure" is in "Build documentation", which IMHO does not make sense.
I assume two aspects motivated the split proposal:
- Interpretation of "Write documentation". I assume you see this as the narrower scope of adding content to files. I see this as the broader scope of "working on documentation" / "contributing to documentation", where the explanation of the file structure and building totally fit in.
- Originally, this was the only documentation-related page. We later grey the style guide (naming is also not ideal because a lot on docstrings is also style) and the tags guide. This creates a certain imbalance, because "Getting started" is in one of the three documentation-related documents.
I'm almost tempted to instead put all three pages together under "Write documentation". Because we now have an imbalance in the top-level structure. Basically each topic is one page, but documentation is 3 (or with this PR 4) pages.
Each section is between 2-4 pages and docs is its own section: But part of the issue is that "build docs" really belongs under development workflow but I dunno if anyone would find it there and the primary motivation for this PR was to make it easier to find the build docs because the current structure buries it. I agree w/ you that my structure doesn't quite work because there's meta "about the docs" documents that don't have a place anymore, and I agree w/ your suggestions about merging up into API and Examples/Tutorials sections (was gonna do that in a follow up) but here's an alternative that I think includes everything Semi explicitly one of the things I'm shaking out here is that tutorials and user guide are ill-defined in terms of content guidelines, and an advantage of making content it's own page is that then it makes more sense to have rst and sphinx gallery as their own sections on a mechanics & conventions page-but the more I think on it the less I think they should be their own big sections cause they're mostly summaries/highlights from the sphinx and sphinx-gallery docs. And it gives space to grow out as we figure out what 'write the docs' content is specific to tutorials and/or userguide. Also a lot of the file structure content overlaps with the readme/rst content, so I'd wanna refine the content in overview/file structure so anything specific to readme/rst gets pushed out. |
Another maybe cleaner break along similar lines is:
|
Hm, the more I think about this the more unclear I am on the right organization. Here are some random and somewhat inconsistent thoughts. Take then as brainstorming not as suggestions or requests.
|
Was editing my previous comment as you posted, but also sphinx-gallery content is relevant to examples, tutorials, and user guide and I strongly believe that the conflating of the three is heavily contributing to the organization and scoping issues of all three sections.
That's sorta where I was going with the edited proposal above:
Yes, that's what I was thinking, but also having them as embedded drop-down kind of like we already do for the git resources |
That's sorta was what I was aiming for here by just pulling build out into it's own page and not doing a bigger restructur, but I can scale back and not rename anything else. I'm being stubborn about build b/c:
But also yes also maybe worth merging the definitely belong together things. I'm slightly iffy on if tagging should be moved into examples or hang off it b/c of the length/special purpose of the doc. |
PR summary
Feedback at sprints was that it's kinda confusing to have the doc build docs meshed w/ the doc formatting docs, so:
Note: looking at this now, probably the cleanest split is
This is part of #26392 and #26196. Follow up would be:
attn: @juanis2112
PR checklist