Skip to content

remove out of date todos on animation.py #28650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

caitlinhat
Copy link
Contributor

PR summary

Removes old and out of date todo's from animation.py

Closes #28626

PR checklist

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@story645
Copy link
Member

story645 commented Aug 2, 2024

I moved the rest of the todos out to #28651 b/c I don't think comments are a good place for em anyway b/c no discoverability, so please remove the entire list.

Also thanks for the cleanup!

@story645 story645 added this to the v3.9.2 milestone Aug 7, 2024
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm not sure if it needs a second review since it's touching .py files but just deleting comments, so leaving this for second review.

@timhoffm timhoffm merged commit 1dea2df into matplotlib:main Aug 7, 2024
40 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 7, 2024
timhoffm added a commit that referenced this pull request Aug 7, 2024
…650-on-v3.9.x

Backport PR #28650 on branch v3.9.x (remove out of date todos on animation.py)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for author
Development

Successfully merging this pull request may close these issues.

[Doc]: Remove old TODO's from animation.py
3 participants