Simplify some code in dviread #28736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find it a bit confusing to use tuple packing and unpacking when the RHS is more complex than a simple constant. Also, if we're assigning an immutable constant to multiple things, it's simpler to use compound assignment intead of the multiple copies in a tuple.
oscargus
approved these changes
Aug 20, 2024
Hopefully it's clearer that this method is doing something stateful now.
timhoffm
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Admittedly, this is a bit of a stylistic preference, but I find it a bit confusing to do stuff like:
when the RHS parts are more complex than a simple value.
And with simple values like
None, that can be simplified to:but with things like
[], then we don't want to do that, so it's simpler to make those separate lines.PR checklist