Skip to content

FIX: remove __array__ method on BasicUnit #28744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

FIX: remove __array__ method on BasicUnit #28744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b3d142
FIX: remove __array__ method on BasicUnit
tacaswell Aug 15, 2024
b4ab05d
Remove __array__ from BasicUnit
ksunden Aug 21, 2024
108565a
Update missing references for moved lines
ksunden Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/missing-references.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@
"lib/matplotlib/pyplot.py:docstring of matplotlib.pyplot.gci:4"
],
"Line2D.pick": [
"doc/users/explain/figure/event_handling.rst:568"
"doc/users/explain/figure/event_handling.rst:571"
],
"QuadContourSet.changed()": [
"lib/matplotlib/axes/_axes.py:docstring of matplotlib.axes._axes.Axes.contour:156",
Expand All @@ -365,7 +365,7 @@
"lib/matplotlib/pyplot.py:docstring of matplotlib.pyplot.contourf:156"
],
"Rectangle.contains": [
"doc/users/explain/figure/event_handling.rst:280"
"doc/users/explain/figure/event_handling.rst:285"
],
"Size.from_any": [
"lib/mpl_toolkits/axes_grid1/axes_grid.py:docstring of mpl_toolkits.axes_grid1.axes_grid.ImageGrid:87",
Expand Down
10 changes: 0 additions & 10 deletions galleries/examples/units/basic_units.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,6 @@ def __getattribute__(self, name):
return getattr(variable, name)
return object.__getattribute__(self, name)

def __array__(self, dtype=object, copy=False):
return np.asarray(self.value, dtype)

def __array_wrap__(self, array, context=None, return_scalar=False):
return TaggedValue(array, self.unit)

Expand Down Expand Up @@ -226,13 +223,6 @@ def __rmul__(self, lhs):
def __array_wrap__(self, array, context=None, return_scalar=False):
return TaggedValue(array, self)

def __array__(self, t=None, context=None, copy=False):
ret = np.array(1)
if t is not None:
return ret.astype(t)
else:
return ret

def add_conversion_factor(self, unit, factor):
def convert(x):
return x*factor
Expand Down