Skip to content

quick fix dev build by locking out numpy version that's breaking things #28752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2024
Merged

quick fix dev build by locking out numpy version that's breaking things #28752

merged 2 commits into from
Aug 23, 2024

Conversation

story645
Copy link
Member

PR summary

locks out numpy version we think is breaking our docs build do to numpy/numpy#26904

PR checklist

@story645 story645 added the Documentation: build building the docs label Aug 22, 2024
@tacaswell
Copy link
Member

doc-requirements.txt is the file we need to pin (as that is what circle uses).

@story645
Copy link
Member Author

story645 commented Aug 22, 2024 •
edited
Loading

I don't even know what circle is doing here cause numpy looks very special cased:

matplotlib/.circleci/config.yml

Lines 105 to 111 in 3f2925b

command: |
python -m pip install --user -r requirements/dev/build-requirements.txt
python -m pip install --user \
numpy<< parameters.numpy_version >> \
-r requirements/doc/doc-requirements.txt
python -m pip install --no-deps --user \
git+https://github.com/matplotlib/mpl-sphinx-theme.git

I edited build requirements cause numpy is listed there first

@story645 story645 force-pushed the doc branch 2 times, most recently from d6a3aaf to cf652f6 Compare August 22, 2024 21:04
@github-actions github-actions bot removed the Documentation: build building the docs label Aug 22, 2024
@tacaswell
Copy link
Member

matplotlib/.circleci/config.yml

Lines 98 to 101 in 3f2925b

parameters:
numpy_version:
type: string
default: ""

We can probably also set it there. 50/50 it works with this run as I'm not sure what pip does when it get the same dep both pinned an unpinned.

@story645
Copy link
Member Author

story645 commented Aug 22, 2024 •
edited
Loading

Also these are linking errors in events so are they related to the bug?

/home/circleci/project/doc/users/explain/figure/event_handling.rst:285: WARNING: py:obj reference target not found: Rectangle.contains [ref.obj]
/home/circleci/project/doc/users/explain/figure/event_handling.rst:571: WARNING: py:obj reference target not found: Line2D.pick [ref.obj]

@QuLogic
Copy link
Member

QuLogic commented Aug 22, 2024

You can cherry pick 108565a for those.

@story645
Copy link
Member Author

Yay doc builds pass and only change is to circle config

@QuLogic QuLogic merged commit aa70f69 into matplotlib:main Aug 23, 2024
39 of 42 checks passed
@QuLogic QuLogic added this to the v3.10.0 milestone Aug 23, 2024
@story645 story645 deleted the doc branch August 23, 2024 01:49
@story645 story645 added the Documentation: build building the docs label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Documentation: build building the docs Documentation
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@story645 @tacaswell @QuLogic @ksunden