Skip to content

add brackets to satisfy the new sequence requirement #28805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

v0lta
Copy link
Contributor

@v0lta v0lta commented Sep 12, 2024

PR summary

Convert the set_data arguments of the frame grabbing example to lists.
This PR closes #28794.

PR checklist

  • [ x ] "closes #28794"
  • [ x ] code is not part of the pip package, it affects the gallery.
  • [ x ] This PR fixes an example in the gallery.
  • [ x ] This PR does not introduce new features.

@github-actions github-actions bot added the Documentation: examples files in galleries/examples label Sep 12, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@QuLogic QuLogic added this to the v3.9-doc milestone Sep 12, 2024
@QuLogic QuLogic merged commit 0cf6e20 into matplotlib:main Sep 12, 2024
21 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 12, 2024
@QuLogic
Copy link
Member

QuLogic commented Sep 12, 2024

Thanks @v0lta! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 12, 2024
timhoffm added a commit that referenced this pull request Sep 12, 2024
…805-on-v3.9.2-doc

Backport PR #28805 on branch v3.9.2-doc (add brackets to satisfy the new sequence requirement)
timhoffm added a commit that referenced this pull request Sep 12, 2024
…805-on-v3.9.x

Backport PR #28805 on branch v3.9.x (add brackets to satisfy the new sequence requirement)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: examples files in galleries/examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants