-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: Fix non-working code object references #28825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note: Failing OSX and free-threaded tests are an unrealted CI issue. |
There's an exception for |
These were not rendered as links in the current docs, because the associated code objects do not exist as targets in the docs. For some reason, sphinx did not complain about it. But it does in some recent PRs (extracted from matplotlib#28560) - I'm unclear why, but anyway the correct solution is to change to explicitly listing the attributes.
dataLim: mtransforms.Bbox | ||
"""The bounding `.Bbox` enclosing all data displayed in the Axes.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a place to put the docstring. IMHO a class-level annotation is the best location (though we normally don't write types in the py files).
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Let's not bother with a manual backport since 3.10 is not that far away. |
Follow up to matplotlib#28825.
Follow up to matplotlib#28825.
Follow up to matplotlib#28825.
Follow up to matplotlib#28825.
Follow up to matplotlib#28825.
These were not rendered as links in the current docs, because the
associated code objects do not exist as targets in the docs. For some
reason, sphinx did not complain about it. But it does in some recent
PRs (extracted from #28560) - I'm unclear why, but anyway the correct
solution is to change to explicitly listing the attributes.