TST: Fix minor issues in interactive backend test #28838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Close the figure immediately, to avoid the deprecation warning about automatically closing figure when changing backends. This test doesn't intend to test the warning, just the change behaviour itself. - Enable the post-`show()` result check everywhere. The comment implies it should only be skipped on `(macOS and Qt5)`, but the condition is actually only enabled on `macOS and (not Qt5)`.
timhoffm
approved these changes
Sep 19, 2024
|
The failed check looks like the thread-safe test where sometimes the sub-process dies for other (? we hope) reasons. |
|
Did that get restarted? I don't see a failed test any more. |
kyracho
pushed a commit
to kyracho/matplotlib
that referenced
this pull request
Oct 10, 2024
- Close the figure immediately, to avoid the deprecation warning about automatically closing figure when changing backends. This test doesn't intend to test the warning, just the change behaviour itself. - Enable the post-`show()` result check everywhere. The comment implies it should only be skipped on `(macOS and Qt5)`, but the condition is actually only enabled on `macOS and (not Qt5)`.
QuLogic
added a commit
to fedora-python/matplotlib
that referenced
this pull request
Jan 24, 2025
…atplotlib#28838)" This reverts commit 7c7f94c.
QuLogic
added a commit
to fedora-python/matplotlib
that referenced
this pull request
May 10, 2025
…atplotlib#28838)" This reverts commit 7c7f94c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
We noticed this while looking at #28588.
show()result check everywhere. The comment implies it should only be skipped on(macOS and Qt5), but the condition is actually only enabled onmacOS and (not Qt5). I'm not sure if this will actually work as it's been disabled for so long unintentionally.PR checklist