Fix flaky labelcolor tests #28858
Merged
Fix flaky labelcolor tests #28858
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For labelcolor={linecolor,markeredgecolor,markerfacecolor}, text will
match the specified attribute if consistent, but fall back to black if
they differ within a single labeled artist.
These tests use 10 random colours out of the ['r', 'g', 'b'] set, so 3
(all red, all green, all blue) out of 3**10 will result in the text
_not_ being black. This is rare (0.0051%), but does happen once in a
while.
Instead, just hard-code some different colours in the test.
timhoffm
approved these changes
Sep 21, 2024
rcomer
approved these changes
Sep 21, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 21, 2024
rcomer
added a commit
that referenced
this pull request
Sep 21, 2024
…858-on-v3.9.x Backport PR #28858 on branch v3.9.x (Fix flaky labelcolor tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
For labelcolor={linecolor,markeredgecolor,markerfacecolor}, text will match the specified attribute if consistent, but fall back to black if they differ within a single labeled artist.
These tests use 10 random colours out of the ['r', 'g', 'b'] set, so 3 (all red, all green, all blue) out of 3**10 will result in the text not being black. This is rare (0.0051%), but does happen once in a while (e.g., https://github.com/matplotlib/matplotlib/actions/runs/10967975776/job/30458622005).
Instead, just hard-code some different colours in the test.
PR checklist