Fix minor issues in stubtest wrapper #28897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list is full of regexs, not globs, so correctly escape the periods to be more specific. Note that to catch `module.__init__`, you need to specific `module`, so there is some slight modification for `matplotlib.tests` / `matplotlib.sphinxext`.
This fixes the "unused allowlist entry" error we see in matplotlib#28874.
cdc8f7f to
1f6bfca
Compare
|
The existing allowlist looks like it was written with fnmatch logic in mind. Would that be simpler/sufficient rather than using regexes? |
|
The allow list is defined by stubtest, and always was a regex. The old one worked since regex |
ksunden
approved these changes
Sep 27, 2024
timhoffm
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
The stubtest allow list is technically composed of regex patterns, so ensure that entries are correctly escaped. Also, don't add an exception if it's already covered by our generic ones. This fixes the problem seen in #28874.
PR checklist