Don't cache exception with traceback reference loop in dviread. #28899
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather, preemptively cache the reference loop by explicitly dropping the traceback. See also db0c7c3.
QuLogic
approved these changes
Sep 27, 2024
|
Do you know that passing None is allowed and not only works by chance? AFAICS, the docs only speak about passing another trackback. If this is not officially supported, we run into the danger that future Python versions break the solution. |
|
Not sure about docs, but it is type hinted as accepting |
|
Ok, in that case it should be fine. |
timhoffm
approved these changes
Sep 28, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather, preemptively cache the reference loop by explicitly dropping the traceback.
See also db0c7c3 (#25470) for a longer description of the problem in another context.
(@tacaswell: I wonder whether using with_traceback(None) would have been a cleaner solution in #25470?)
PR summary
PR checklist