polar error bar fix #28924
polar error bar fix #28924
Conversation
…y, sign of y axis condition was adjusted to align properly
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Hi @vas1l thank you for your interest in contributing to Matplotlib. I'm sorry to hear you have problems installing - we have the incubator gitter chat for new contributors to get help, so you are very welcome to ask any questions there. There is also an option to use GitHub Codespaces and work in the browser instead of installing locally. The continuous integration checks here show that an existing unit test for errorbar is failing, so something is not quite right with your fix. If you get a local or codespaces install working then you could investigate that. However, as you know, there is already an open PR for this issue at #28905. We usually take the first PR opened against an issue and in this case #28905 seems closer to completion so likely it will be merged rather than this. If you think #28905 could be improved then you are welcome to leave a review there. I am sorry but I am going to close this as a duplicate. |
Please feel free to review and or test this as I was unable to actually create the plot due to issues with installing python and matplotlib on my local machine here.
This was supposed to be a bug fix for issue number #28885 linked here : #28885
I changed the rotation coefficient in the lines showed in the original post and the sign of the rotate call to match the new coefficient.
import matplotlib.pyplot as plt
import numpy as np
theta = np.arange(0, 2 * np.pi, np.pi / 8)
r = theta / np.pi / 2 + 0.5
fig = plt.figure(figsize=(10, 10))
ax = fig.add_subplot(projection='polar')
ax.set_theta_zero_location("N")
ax.set_theta_direction(-1)
ax.errorbar(theta, r, xerr=0.1, yerr=0.1, capsize=7, fmt="o", c="seagreen")
ax.set_title("Pretty polar error bars")
plt.show()