closes #24617. adds figsize alias and fixed #25091 subplot param getter #28936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is my first open source contribution. I don't know how the setter works as I used someone else's working one, but I did get the getter to pass it's test. Added a figsize alias as well.
|
Thanks for the contribution. We're quite busy getting the 3.10 release out. We'll have a look later. |
|
Without having looked too much into details, at the least, this should pass tests and linting. |
|
Is this issue closed? Can I start working on it? I'm a new contributor and I have some ideas but will get in touch if I have any questions if the issue is still open. |
|
take |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First open source contribution. I saw #25901 and noticed that he was in the wrong scope for his subplot getter to be returning the appropriate params, so I set one up in the correct class and gave the figure class a return all subfigure's subplot getter. Also added alias for size_inches -> figsize
[✔️ ] "closes #24617 is in the body of the PR description to link the related issue
[✔️ ] new and changed code is tested
[N/A] Plotting related features are demonstrated in an example
[ N/A] New Features and API Changes are noted with a directive and release note
[ ✔️] Documentation complies with general and docstring guidelines