CI: Resolve mypy stubtest build errors #28978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc5a3d4 to
4b36b7a
Compare
Linting Linting Simplify check Import even though unused to smoke test
4b36b7a to
e10cd28
Compare
scottshambaugh
commented
Oct 15, 2024
| @@ -15,7 +15,8 @@ | |||
| from matplotlib import _c_internal_utils | |||
|
|
|||
| try: | |||
| from matplotlib.backends.qt_compat import QtGui, QtWidgets # type: ignore # noqa | |||
| from matplotlib.backends.qt_compat import QtGui # type: ignore[attr-defined] # noqa: E501, F401 | |||
There was a problem hiding this comment.
I kept this import even though unused in order to smoke test the module
scottshambaugh
commented
Oct 15, 2024
| @@ -2976,7 +2976,7 @@ def test_scatter_singular_plural_arguments(self): | |||
|
|
|||
|
|
|||
| def _params(c=None, xsize=2, *, edgecolors=None, **kwargs): | |||
| return (c, edgecolors, kwargs if kwargs is not None else {}, xsize) | |||
| return (c, edgecolors, kwargs, xsize) | |||
There was a problem hiding this comment.
kwargs defaults to a dict if not provided, so the check here was redundant and raising an error
QuLogic
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
I believe there must have been a dependency update in the last day or two that made mypy checks more strict, as Mypy Stubtest CI began failing with the below errors:
This resolves those with more specific ignore comments. Note that running
mypywas not broken, this specifically came up when runningtox -e stubtest. I did not check each one to see if the#ignorecomments were still necessary.PR checklist