FIX: contourf hatches use multiple edgecolors #28993
Conversation
lib/matplotlib/contour.py
Outdated
| @@ -1259,12 +1259,16 @@ def draw(self, renderer): | |||
| super().draw(renderer) | |||
| return | |||
| # In presence of hatching, draw contours one at a time. | |||
| all_edgecolors = self.get_edgecolors() | |||
There was a problem hiding this comment.
| all_edgecolors = self.get_edgecolors() | |
| edgecolors = self.get_edgecolors() |
Slight preference for leaving out the all_ prefix. It does not convey information.
cde45c4 to
08e6552
Compare
|
If possible, let's also backport to 3.9 to have a version that supports both the old and new syntax and thus have a smoother transition. |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…3.9.x Backport PR #28993 on branch v3.9.x (FIX: contourf hatches use multiple edgecolors)
PR summary
Fixes #28990. I think it would be good to get this minor fix in for v3.10 since the example from the issue will otherwise not be possible to plot (and it is possible at v3.9 using the deprecated
collectionsattribute).I note that passing edgecolors to
contourfresults in a warning that the parameter is ignored. This seems inconsistent with being able to set them afterContourSetinstantiation. However, I propose to ignore the inconsistency for now and think about it later when a release is not imminent.PR checklist