Centralize data limit evaluation in Artist class (#28816) #28996
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
This pr claims to have changed 14k files and more than 4 million lines of code. Presumably something went wrong with your commit that you will have to fix on your end before we can reasonably review this. I'd also suggest you include more discussion about how this is going to work because this is a pretty fundamental change that requires careful design |
|
I'm going to mark this as "draft" for now. Please mark it as "ready for review" when you are ready. In the meantime, if you need help, feel free to ask questions here. Or you may prefer to ask them in our incubator gitter room. |
PR summary
This pull request implements the centralization of data limit calculation logic into the Artist subclasses. The aim is to move the responsibility for calculating the data limits to each specific Artist, such as Line2D, Rectangle, Circle, and other subclasses. This change allows for the data limit logic to be maintained locally in each class, facilitating reuse and ensuring consistency in data limit calculation.
This change addresses the issue described in #28816, which requests refactoring to move the logic directly into the Artists, eliminating duplicated logic and making the code more modular.
PR checklist