Add get_data_limits method to Artist class #29000
Conversation
There was a problem hiding this comment.
Thank you for your contribution @gabisoaresm. However, to close the linked issue we need a comprehensive change that implements the overrides you mention in the child classes, and also makes use of them.
Please also note that docstrings should be written in English.
There was a problem hiding this comment.
@gabisoaresm thanks for you willingness to contribute. Though I have to say this is far from adequate. Only writing a placeholder is maybe 1% of the task and has no value by it's own. A PR addressing #28816 must also do the refactoring. Otherwise, we don't know whether it's feasible or the API is appropriate. Please also note that all docstrings are English.
|
I'm going to close this one because the solution does not look likely to be completed here. I will be very happy to be proved wrong and we can re-open at any time. |
PR summary
This pull request introduces the get_data_limits method to the Artist class. This method serves as a placeholder for subclasses to override and implement their own logic to calculate data limits. This change helps centralize the logic of calculating data limits in the Artist class, simplifying future extensions and customizations for different plot elements. The subclasses still need to be modified to fully benefit from this centralization.
Closes #28816.
PR checklist