FIX: Don't set_wmclass on GTK3 #29035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method is deprecated, and according to docs should just not be used: https://docs.gtk.org/gtk3/method.Window.set_wmclass.html The docs suggest gtk_window_set_role(), but AFAICS this is only helpful if one want to place the window in a certain position when restarting a session. I assume we don't want/need that.
tacaswell
approved these changes
Oct 29, 2024
Ok then. |
greglucas
approved these changes
Oct 29, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method is deprecated, and according to docs should just not be used: https://docs.gtk.org/gtk3/method.Window.set_wmclass.html
The docs suggest gtk_window_set_role(), but AFAICS this is only helpful if one want to place the window in a certain position when restarting a session. I assume we don't want/need that.
This might also resolve this test failure #27766 (comment) - t.b.c.