Fix bbox of polar Axes #29051
Open
Fix bbox of polar Axes #29051
+3,047
−2,826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of generating a throwaway `Wedge` class to calculate the boundaing box for sizing, re-use the one that is the `Axes` patch (unless it was never set). This also removes the redundant re-calculation to resize the `Axes` patch during draw. This does in turn require tweaking the transform, as the calculation uses a slightly different domain, but it should be more robust to changes in the bbox calculation.
No longer expand the wedge bbox to make a square, but instead export at whatever size it has. Then also apply its aspect ratio to the Axes itself, so that the Axes' 'active' position is correct. This allows wedge-shaped PolarAxes to expand to fill their allocated space.
Since these labels are currently just an x/y analog (and not tied to the axis orientation), they need to "see" the other axis in order to avoid overlap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Polar Axes previously scaled its position into an equal area box; this was a simplification in order to preserve the aspect ratio. Now the actual position is modified to fill the requested position, while modifying the aspect ratio so that the box is tight to the polar wedge.
Also, this tweaks the positioning of the x/y labels so that they won't overlap the ticks. Note on polar axes, these are not aligned with the actual
Axis, but just in the place they would be for a Cartesian Axes. I think making them aligned to the Axis would be a good idea, but is something larger that we'd have to possibly copy frommpl_toolkits.Fixes #10264
PR checklist