DOC: Update page to note installation for ninja library #29083
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
doc/devel/development_setup.rst
Outdated
| @@ -212,7 +212,7 @@ Additionally, the following non-Python dependencies must also be installed local | |||
|
|
|||
| * :ref:`c++ compiler<compile-dependencies>` | |||
| * :ref:`documentation build dependencies <doc-dependencies-external>` | |||
|
|
|||
| * :ref:`ninja <ninja-dependencies>` | |||
There was a problem hiding this comment.
can you make this the first thing in the list since you need ninja before installing c++ -> basically mirroring the order in the dependencies file
|
I think my gut reaction is that Ninja is not special enough its own section here. I will acknowledge that it is in a bit of an odd place in that it is really an external (non-python) dependency, but they happen to package it on pypi, which is sometimes the most convenient place for Python users to get it. My current leaning would be to put it in the "Compilers" section (perhaps with a section rename to e.g. "Compilers and external build tools" or similar) as really that is what it is. |
@tacaswell suggested similar, only reason I suggested different section is b/c the compilers section is so rich w/ c++ compiler information. Which maybe:
But also if we're running that away with it, if @jimmyshah doesn't updated in a few days than I may just add a commit to this PR that makes those changes. |
|
Apologies for the delay here, just catching up on this now. I'm having a little bit of trouble following the conversation:
If @story645 wants to push this through, also totally fine by me. I can try seeing this through as well, whatever works! |
It's the one you linked to, those are the tools for building compiled extensions. And would much prefer that you do it if you're up for it! |
|
I implemented the feedback from the conversation above, let me know if I can do anything else. Thank you for guiding me through the PR @story645! |
|
Sorry for dropping the ball here @jimmyshah - do you have time to finish this up or can I take over? |
1b9bcbb to
9b77225
Compare
|
made the requested changes since "no ninja" has been coming up a bunch lately |
|
Thanks @jimmyshah! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
PR summary
At the sprints for PyData NYC, as I was setting up the repo for local development, I ran into an issue with installing
ninjadirectly from the dev requirements file. After chatting with @story645, she suggested I update the documentation and make a separate section to make external dependency onninjamore clear.This PR changes the docs page to add a new section for the
ninjaexternal dependency, and removes it from the Python section. I also addedninjato the list of external dependencies in the documentation.PR checklist