Relax conditions for warning on updating converters #29154
Merged
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow sub/superclass without warning. This was motivated by Pandas, as they have several instances of the same class in the registry. We also had this internally, though resolved that by using the same instance for multiple registry entries rather than by relaxing the warning. This becomes impractical when dealing with downstream. It may have been sufficient to allow only identical types, but to be safe, decided to allow both sub- and superclass relationships. The purpose of the warning was that it gets overwritten without heeding prior data provided which would break in unexpected ways. The most common case for this is when one converter class operates on multiple data types, but separate instances of the class are in the registry. So while the previous data is compatible the equality check still failed. Requiring downstream to implement equality checks seems impractical. Additionally used both `is` and `==` for the earlier short circuit, which should in most cases be identical operations, but just in case.
QuLogic
approved these changes
Nov 19, 2024
|
Looks like the test was expecting the stricter behaviour. |
|
It looks like macOS Azure is hitting actions/runner-images#10984 |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 21, 2024
QuLogic
added a commit
that referenced
this pull request
Nov 22, 2024
…154-on-v3.10.x Backport PR #29154 on branch v3.10.x (Relax conditions for warning on updating converters)
ksunden
pushed a commit
to ksunden/matplotlib
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow sub/superclass without warning.
This was motivated by Pandas, as they have several instances of the same class in the registry.
We also had this internally, though resolved that by using the same instance for multiple registry
entries rather than by relaxing the warning. This becomes impractical when dealing with downstream.
It may have been sufficient to allow only identical types, but to be safe, decided to allow both
sub- and superclass relationships.
The purpose of the warning was that it gets overwritten without heeding prior data provided which
would break in unexpected ways.
The most common case for this is when one converter class operates on multiple data types, but
separate instances of the class are in the registry. So while the previous data is compatible the
equality check still failed. Requiring downstream to implement equality checks seems impractical.
Additionally used both
isand==for the earlier short circuit, which should in most cases beidentical operations, but just in case.
PR summary
PR checklist