Skip to content

Adding figratio to matplotlib to allow dynamic change of figure size based upon width/height and aspect #29262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arkapudota2003
Copy link

PR summary

PR checklist

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@timhoffm
Copy link
Member

timhoffm commented Dec 9, 2024

Thanks for your willingness to contribute. I assume this should address #28758? - Please always link the related issues, as stated in the PR checklist.

The PR does not refect the state of the discussion in #28758. All we agreed upon so far was to accept None as component in the tuple given to the figsize keyword argument, with the meaning: Take that component from rcParams["figure.figsize"]; i.e. plt.figure(figsize=(None, 3) and plt.figure(figsize=(3, None)

@tacaswell tacaswell mentioned this pull request Dec 10, 2024
@timhoffm
Copy link
Member

@arkapudota2003 do you plan to continue working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for author
Development

Successfully merging this pull request may close these issues.

2 participants